Private Message Button on topic authors posts - Code Review Request

February 2, 2015, 3:19 pm

≫ Next: Installing plugins without Docker? (Windows 8 and Vagrant Setup)

≪ Previous: Color changes can't be previewed?

I'm adding a "Private Message" button to topic author topic and posts within a specific category to make "Private Message" more accessible as some users are unable to reply in those categories due to permissions requirements.

Could you review the following JavaScript code?

It works and displays the Private Message dialog, with quoting support.

It uses Discourse.__container__.lookup which causes an air of code smell for me.

window.replyAsNewPrivateMessage = function (target) {
    var postId = $(target).closest('.boxed').data('post-id'),
        composerController = Discourse.__container__.lookup('controller:composer'),
        quoteController = Discourse.__container__.lookup('controller:quote-button'),
        quotedText = Discourse.Quote.build(quoteController.get('post'), quoteController.get('buffer')),
        topicController = Discourse.__container__.lookup('controller:topic'),
        post = topicController.get('postStream.posts').findBy('id', postId);


    quoteController.deselectText();

    composerController.open({
        action:      Discourse.Composer.PRIVATE_MESSAGE,
        usernames:   post.get('username'),
        archetypeId: 'private_message',
        draftKey:    'new_private_message'
    }).then(function () {
        return Em.isEmpty(quotedText) ? Discourse.Post.loadQuote(post.get('id')) : quotedText;
    }).then(function (q) {
        var postUrl = "" + location.protocol + "//" + location.host + (post.get('url')),
            postLink = "[" + topicController.get('title') + "](" + postUrl + ")";
        composerController.appendText(I18n.t("post.continue_discussion", {postLink: postLink}) + "\n\n" + q);
    });
};

Any comments welcome - Thanks!

Posts: 3

Participants: 3

Read full topic

↧

Installing plugins without Docker? (Windows 8 and Vagrant Setup)

February 2, 2015, 3:31 pm

≫ Next: Migrating from one Docker server to another

≪ Previous: Private Message Button on topic authors posts - Code Review Request

@Nixjust wrote:

Hello everyone,

Is it possible to install plugins without the use of Docker?

I've been researching some other threads like these two, and it seems to imply the app.yml can only be found with a Docker set up:

meta.discourse.org/t/where-is-the-app-yml-file/22853

meta.discourse.org/t/how-to-edit-app-yml-file/20569

However, I would very much like to test out the plugins on my Windows 8 and Vagrant VM setup, and develop on the local host/VM like I've been doing.

Is this possible? Thanks in advance.

Edit:

Just for more detail, I'm trying to install this colored font plugin for Discourse:

https://github.com/discourse/discourse-bbcode-color

Posts: 5

Participants: 2

Read full topic

↧

Migrating from one Docker server to another

February 2, 2015, 3:40 pm

≫ Next: Moved post notification not dismissing when clicked

≪ Previous: Installing plugins without Docker? (Windows 8 and Vagrant Setup)

@samnazarko wrote:

Hi

I am trying to migrate my Discourse instance from one Ubuntu 14.04 server running Docker to another and could not find a lot of documentation about this.

I have installed Docker on the new server, but I am not sure how to migrate the old forum. I know I can do docker save. But I have some questions:

How do I know the name of the container to run 'docker save' on?

Will docker load < sometar on the other box recreate /var/discourse and all the YAML so I can just run ./launcher app rebuild and ./launcher app start?

Thanks

Sam

Posts: 5

Participants: 2

Read full topic

↧

Moved post notification not dismissing when clicked

February 2, 2015, 3:56 pm

≫ Next: Autoclosing topic causes 50x errors

≪ Previous: Migrating from one Docker server to another

@DeanMarkTaylor wrote:

Clicking the moved post(s) notification initially dismisses it and loads the linked staff post...
... but if you reload the page - the notification is still there highlighted in blue.

Posts: 1

Participants: 1

Read full topic

↧

Autoclosing topic causes 50x errors

February 2, 2015, 4:13 pm

≫ Next: No text in category badges on Firefox mobile view

≪ Previous: Moved post notification not dismissing when clicked

@loopback0 wrote:

As spotted over yonder.

what.thedailywtf.com

Autoclosing topics cause discodowntime

Continuing the discussion from Cooties in 10?: well that explains why i never can post anywhere near the end of a topic in onepost lately..... @sam, @PJH whats going on?

At least 3 instances today where, as the autoclosure time hits, the server experiences "issues" with 500, 502, 504 errors being thrown for approx 10-15minutes.

Posts: 9

Participants: 4

Read full topic

↧

No text in category badges on Firefox mobile view

February 2, 2015, 4:35 pm

≫ Next: Issue: Bleeding-edge external SSO prohibits returning to host app

≪ Previous: Autoclosing topic causes 50x errors

@DavidGNavas wrote:

I use Firefox on my Nexus 4 for visiting meta. and other instances.
Since the changes from "the end of clown vomit" i think, there is no text on category badges when you are reading on firefox, mobile view.
I though it was only on Android but you can test it on a Firefox window in a desktop device too: https://meta.discourse.org/?mobile_view=1

This is meta, with bars (Firefox on Mac):

Captura de pantalla 2015-02-03 a las 1.06.09.png737x416 69.9 KB

This is the instance of my organization, updated minutes ago, with boxes (Firefox on Ubuntu):

captcp.png462x576 34.3 KB

Posts: 4

Participants: 3

Read full topic

↧

Issue: Bleeding-edge external SSO prohibits returning to host app

February 2, 2015, 7:12 pm

≫ Next: High RAM and Cache utilization for discourse 1.1.3

≪ Previous: No text in category badges on Firefox mobile view

@gregoryaveryweir wrote:

We are pinned to the tests-passed branch of Discourse, and we've found that the following commit broke our SSO solution: https://github.com/discourse/discourse/commit/f5e0cf63f666549103d466c9f9dcf08b57fe13d4

We have login on our (non-Discourse) site, and as part of the login process we redirect to Discourse with a return_path to the host site (on a different subdomain) so that we can continue with the normal flow and let Discourse be logged in "in the background" without it disrupting our users' flow. If users later visit the forums, they find themselves pleasantly still logged in.

However, from what I can tell, this commit restricts return_path to being on the Discourse subdomain. This means that we can't log in to Discourse and then return to our own site.

For the moment we can pin ourselves to 1.2.0.beta5, but is it possible to provide a whitelist or otherwise disable this restriction on the return_path domain?

Posts: 7

Participants: 5

Read full topic

↧

High RAM and Cache utilization for discourse 1.1.3

February 2, 2015, 9:03 pm

≫ Next: Trello card onebox

≪ Previous: Issue: Bleeding-edge external SSO prohibits returning to host app

@irealty wrote:

RAM utilization recommended for discourse forum is 2 GB. We have installed Discourse 1.1.3 version and at present site is in trial and have hardly any traffic. It might be used by 10-15 people max and still RAM (2.0- 2.5 GB) and cache memory utilization is very high . Please state what could be the reason behind this or how it can be reduced. We have hosted website on AWS t2.medium EC2 node.

Is there any benchmark for these resources utilization or do we need to upgrade any resource or something. Speed of site is also really slow. Number of visitors to site will increase when trial phase is over, so at that time will we need some high RAM or cache memory or multiple CPUs? Refer image for resource utilization.

Please suggest how we can solve the problem.

Posts: 7

Participants: 4

Read full topic

↧

Trello card onebox

February 2, 2015, 9:05 pm

≫ Next: Group member pages only showing first 50 members alphabetically

≪ Previous: High RAM and Cache utilization for discourse 1.1.3

@badevguru wrote:

Seems like an obvious onebox but does not appear to be enabled at the moment.

Would generate the typical default trello view of a card inside a box representing the list the card is embedded in.

Posts: 6

Participants: 4

Read full topic

↧

Group member pages only showing first 50 members alphabetically

February 3, 2015, 1:13 am

≫ Next: Edit lock when editing posts; especially wiki post

≪ Previous: Trello card onebox

@PJH wrote:

For (quick) example https://meta.discourse.org/groups/trust_level_2/members (TL1 and TL0 are the same)

If a group has more than 50 members,it appears only the first 50 (alphabetically by user id) are shown. Scrolling to the bottom, I'd expect more to be loaded.

Posts: 1

Participants: 1

Read full topic

↧

Edit lock when editing posts; especially wiki post

February 3, 2015, 5:31 am

≫ Next: I have a question to images

≪ Previous: Group member pages only showing first 50 members alphabetically

@erlend_sh wrote:

The "Wiki Post" feature is more hazardous than useful on any forum with more than 10 active users at any one time. The fact that users can overwrite one another's edits when they end up doing edits at the same time is a huge bummer.

Couldn't we just take a page out of WordPress' book and implement post edit locking? This can come in handy for that rare event when two moderators end up editing the same post as well.

Posts: 4

Participants: 4

Read full topic

↧

I have a question to images

February 3, 2015, 6:05 am

≫ Next: Wrong translation

≪ Previous: Edit lock when editing posts; especially wiki post

@Pirat wrote:

if you change the picture Profile Background or avatar, old removed?

Posts: 4

Participants: 2

Read full topic

↧

Wrong translation

February 3, 2015, 8:48 am

≫ Next: Will Discourse apply for Google Summer of Code 2015?

≪ Previous: I have a question to images

@Johannes_Eck wrote:

Is there any possibility to adjust an translation? The german translation is "Du sind 5 neue ..." and the correct translation is "Es sind 5 neue ..."

Thanks in advance!

Fehler_Translation.png711x331 47.4 KB

Posts: 3

Participants: 3

Read full topic

↧

Will Discourse apply for Google Summer of Code 2015?

February 3, 2015, 9:49 am

≫ Next: I've accidentally "blocked a spammer". Any way to unblock their IP?

≪ Previous: Wrong translation

@erlend_sh wrote:

GSoC 2015 will start accepting applications in a week. I think Discourse should apply. My offer to draft your application for you still stands.

Prospective Student Projects

Could be one big one or a combination of related ones, e.g. "GitHub integrations".

What is the most awesome plugin for Discourse, that does not yet exist? extensibility

I would like to create this topic to inspire budding plugin authors. As a user what is the most amazing plugin for Discourse you could imagineer?

Using Discourse as a chat application meta

Hello all I don't know if I'm in the right category, if not, feel free to move. I was wondering if Discourse could be used as a chat application. A group of friends of mine used to have an irc channel where we gather when we have time. With our lives and work taking more and more time, the maximum number of simultaneous participant is never more than 4 to 5. Most of the conversations are a-synchronous (even the simplest questions such as "How are you?" get answers maybe 24h later). Some conver…

What cool badge queries have you come up with? feature

So there are lots of potential badges that we can come up with using SQL queries. I thought I'd start a topic for people to share some of the queries and badges they've created. I for one am looking forward to seeing some cool inspiration!

You say it's your birthday?   spec

One feature that might be fun as a plugin (can't see this as core) -- when it is your birthday, show a cake Emoji next to your name. [image] Reddit does something like this "cakeday" and it's fun. But we could use two possible dates: the day you joined that Discourse (default) your actual birthday, as entered in a custom birthday field in user profile, since we don't -- and have no plans to -- have this field by default Anyway I think this is a fun feature and would make an excellent…

Add "select below" and "select above" admin post selection action   spec

It happens a lot that when splitting topics, you more-or-less need to select all posts downstream of a certain post to get a proper split. This is a pain in the ass in the current admin interface: you have to manually walk down all the posts and click them, though "select+replies" helps a bit. the selection UI is crazy slow for reasons I don't fully understand. Like absurdly slow, 1 second wait after each click. So I suggest we add an "above" and "below" button after "select" to make it ea…

Add a "merge multiple responses" admin post selection action   spec

For users that insist on posting multiple sequential replies, especially short ones, it would be nice to have a "merge posts" option appear when you use the admin wrench to begin selecting posts in a topic, and then select a few posts by the same user in sequence: [image] This does make it somewhat ambiguous what happens when 3 different replies "directed" at 3 different users are combined. Not sure exactly how to handle that, but for now I would just remove any explicit replies as part of t…

Improved Group Members Management   spec

Following up on the bug that our Admin UI only shows up to 201 members for groups, I'd like to propose the following changes to Group-Admin interface. allow group editing on user First, allow direct editing of Groups on User-Admin-Interface (seriously, how is that still missing?): [image] Replacing the "primary group" feature with the select2-autosuggest for existing groups. I am still unsure about whether or not show the trust groups here, too (as they are not actually editable). And mo…

Implement Gist onebox   spec

We had a naive implementation for Gist oneboxes, however it failed miserably due to dynamic loading: In particular this: To resolve this issue: The Gist oneboxer should use a similar approach to the blob oneboxer It must take care of truncating huge files It must take care of displaying gists with multiple files Syntax highlighting is to be handled by our pre-existing syntax highlighting engine, all the onebox is to do is to decorate divs with the guessed syntax. I thought of poss…

Trello card onebox feature

Seems like an obvious onebox but does not appear to be enabled at the moment. Would generate the typical default trello view of a card inside a box representing the list the card is embedded in. [image]

eviltrout:

Ideally we'd have a set of plugins for various chatrooms, like discourse-hipchat, discourse-slack, etc, that would all expose the same event system.

Then we could do code like DiscourseEvent.trigger(:notify_chat, "some chatroom text") and have it work regardless of your chat software.

Posts: 4

Participants: 3

Read full topic

↧

I've accidentally "blocked a spammer". Any way to unblock their IP?

February 3, 2015, 10:08 am

≫ Next: Meetup oneboxes (support for hidden oEmbed)

≪ Previous: Will Discourse apply for Google Summer of Code 2015?

@Aspirety wrote:

So yeah, this is embarassing. In the process of trying to delete an old account that wouldn't delete for some reason (that's an issue for later), I ended up deleting the wrong account. Basically the user had two accounts, wanted the first one deleted, and after changing ownership of their one old post I accidentally went and attempted to "delete spammer" out of desperation, forgetting that I'd changed the ownership and deleted the wrong account. Yeah, I'm an idiot...

But I go to the blocked list and I can't find anything. I need to find a way to unblock this IP so the user can make a new account. Is there any way to do this? Thanks...

Posts: 5

Participants: 4

Read full topic

↧

Meetup oneboxes (support for hidden oEmbed)

February 3, 2015, 10:16 am

≫ Next: Best way to access navigation icons from plugin?

≪ Previous: I've accidentally "blocked a spammer". Any way to unblock their IP?

@eviltrout wrote:

It turns out some sites like Meetup.com support oEmbed but don't link to it using HTML. I've upgraded our onebox engine to support providing endpoints for URLs that are not advertised, and now our meetup embed looks a whole lot better!

February EmberTO Meet-up

Thursday, Feb 5, 2015, 6:30 PM

Location details are available to members only.
43 Emberists Attending

Hey Folks, We're trying new (read: bigger) venues on for size in 2015, starting with the wonderful new ExChange space in the BrightLane building for our February meet-up. This month we have our own Jorge Villalobos waxing on building faux-dynamic, SEO-friendly sites with Ember + Middleman, Precision Nutrition's Justin Giancola will be giving a ligh...

Check out this Meetup →

Thanks a lot to everyone who participated in this issue on github!

Posts: 3

Participants: 3

Read full topic

↧

Best way to access navigation icons from plugin?

February 3, 2015, 10:53 am

≫ Next: Bug for adding header into discourse forum

≪ Previous: Meetup oneboxes (support for hidden oEmbed)

@JSey wrote:

I am currently thinking to add a button for a plugin in the button ul in the header like this:

…but I'm wondering how to access the DOM elements in a clean way - there is no ID anywhere in the
<div class="panel clearfix">
  <ul class="icons clearfix" role="navigation">
      <li class="notifications">
elements, so no $("#nav").append(mybutton); - do I really need to access it via the CSS class? Is this sufficiently safe or likely to change somewhere in the future? Or is there another (more elegant) way to accomplish this?

Posts: 3

Participants: 2

Read full topic

↧

Bug for adding header into discourse forum

February 3, 2015, 11:49 am

≫ Next: Upgrade path for very old versions of discourse?

≪ Previous: Best way to access navigation icons from plugin?

@parenthere wrote:

I have tried to add into custom css/html header section.
/admin/customize/css_html
but the result is that the meta content add into part, I have tried to rebuild, or reboot or re-edit several times.
It always keeps the same.
Please help me with it. You can see the source code in my website: view-source: http://www.heartemma.com/
The meta data is below .
Thanks
Emma Fu

Posts: 3

Participants: 2

Read full topic

↧

Upgrade path for very old versions of discourse?

February 3, 2015, 1:37 pm

≫ Next: Updating Discourse causes white on white categories

≪ Previous: Bug for adding header into discourse forum

@PeterGrace wrote:

I am running 0.9.8.11, non-dockerized. I'd like to jump to using the docker container to facilitate smoother upgrades in the future, but I don't see mentions of how I might import the old database and migrate it to the latest needed version. Is there a way to handle this in a somewhat-clean manner? Can anyone direct me to some documentation, if I missed this topic being covered elsewhere?

Posts: 2

Participants: 2

Read full topic

↧

Updating Discourse causes white on white categories

February 3, 2015, 6:16 pm

≫ Next: Discourse stopped running if I choose user preferences setting - Consider topics new when "I haven't viewed them yet"

≪ Previous: Upgrade path for very old versions of discourse?

@Jake_Jackson wrote:

Hi,

After the latest update (Beta 6) the category background on the home page is now a little stripe. However this UX change in conjunction with using a white category foreground colour makes the text unreadable.

category-setting.png710x606 14 KB

home-page-discourse.png1110x756 47.2 KB

Previously when the background color was behind the text this looked perfectly fine.

Is there custom CSS I can add to make the category background color show behind the text? I would rather not change the text color to black as the contrasting colors are harder to read on the individual category pages where the background image is still behind the text.

Posts: 7

Participants: 4

Read full topic

↧

Prospective Student Projects

February EmberTO Meet-up

Latest Images